Various fixes

Author: SachaG

packages/example-forum/lib/components/comments/CommentsItem.jsx

@@ -22,7 +22,6 @@ class CommentsItem extends PureComponent {
   }
 
   replyCancelCallback(event) {
-    event.preventDefault();
     this.setState({showReply: false});
   }
 
@@ -36,7 +35,6 @@ class CommentsItem extends PureComponent {
   }
 
   editCancelCallback(event) {
-    event.preventDefault();
     this.setState({showEdit: false});
   }
 

packages/example-forum/lib/modules/posts/parameters.js

@@ -9,9 +9,9 @@ import moment from 'moment';
 import { addCallback } from 'meteor/vulcan:core';
 
 // Add 'after' and 'before' properties to terms which can be used to limit posts in time.
-function addTimeParameter (parameters, terms, apolloClient) {
+function PostsAddBeforeAfterParameters (parameters, terms, apolloClient) {
 
-  // console.log('// addTimeParameter')
+  // console.log('// addBeforeAfterParameters')
 
   if (typeof parameters.selector.postedAt === 'undefined') {
 
@@ -86,4 +86,4 @@ function addTimeParameter (parameters, terms, apolloClient) {
 
   return parameters;
 }
-addCallback('posts.parameters', addTimeParameter);
+addCallback('posts.parameters', PostsAddBeforeAfterParameters);

packages/example-forum/lib/server/posts/callbacks/embedly.js

@@ -5,7 +5,7 @@ Callbacks to add media/thumbnail after submit and on edit
 */
 
 import { addCallback, getSetting } from 'meteor/vulcan:core';
-import Embed from 'meteor/vulcan:embed';
+import { Embed } from 'meteor/vulcan:embed';
 
 const embedProvider = getSetting('embedProvider');
 

packages/example-forum/lib/server/posts/callbacks/other.js

@@ -85,7 +85,12 @@ addCallback('users.remove.async', UsersRemoveDeletePosts);
 Posts.increaseClicks = (post, ip) => {
   if (getSetting('forum.trackClickEvents', true)) {
     // make sure this IP hasn't previously clicked on this post
-    const existingClickEvent = Events.findOne({ name: 'click', 'properties.postId': post._id, 'properties.ip': ip });
+    let existingClickEvent = false;
+    try {
+      existingClickEvent = Events.findOne({name: 'click', 'properties.postId': post._id, 'properties.ip': ip});
+    } catch (error) {
+      console.error(error);
+    }
 
     if (!existingClickEvent) {
       // Events.log(clickEvent); // Sidebar only: don't log event

packages/example-forum/lib/server/posts/callbacks/voting.js

@@ -14,7 +14,7 @@ import { performVoteServer } from 'meteor/vulcan:voting';
  */
 function PostsNewUpvoteOwnPost(post) {
   var postAuthor = Users.findOne(post.userId);
-  return {...post, ...performVoteServer({ document: post, voteType: 'upvote', collection: Posts, user: postAuthor })};
+  return {...post, ...performVoteServer({ document: post, voteType: 'upvote', collection: Posts, user: postAuthor, updateDocument: true })};
 }
 
 addCallback('posts.new.after', PostsNewUpvoteOwnPost);

packages/example-forum/lib/server/posts/out.js

@@ -14,10 +14,7 @@ Picker.route('/out', ({ query}, req, res, next) => {
 
     try {
 
-      // decode url just in case
-      const decodedUrl = decodeURIComponent(query.url);
-
-      const post = Posts.findOne({url: {$regex: escapeStringRegexp(decodedUrl)}}, {sort: {postedAt: -1, createdAt: -1}});
+      const post = Posts.findOne({url: {$regex: escapeStringRegexp(query.url)}}, {sort: {postedAt: -1, createdAt: -1}});
 
       if (post) {
         const ip = req.headers && req.headers['x-forwarded-for'] || req.connection.remoteAddress;