Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Component models #5843

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Cleanup Component models #5843

merged 6 commits into from
Jun 3, 2024

Conversation

xQwexx
Copy link
Contributor

@xQwexx xQwexx commented Apr 25, 2024

This pr clean up the component models.

@xQwexx xQwexx force-pushed the components-cleanup branch from 286e4c7 to 4c61b0f Compare April 25, 2024 12:37
@artf
Copy link
Member

artf commented May 28, 2024

Hey @xQwexx sorry my bad I left this PR open for too long, but are you able to fix conflicts first before the review, please?

@xQwexx
Copy link
Contributor Author

xQwexx commented May 28, 2024

@artf Np, I updated it 👍

Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏, commented just one thing

src/dom_components/model/Component.ts Outdated Show resolved Hide resolved
@artf artf merged commit 679e23c into GrapesJS:dev Jun 3, 2024
2 checks passed
@xQwexx xQwexx deleted the components-cleanup branch June 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants