-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Can't set background:none in mobile version using styles panel #5583
Comments
not a bug but a missing feature, we'll need to extend the stack type with a new configuration for "empty" values. |
Correct
I'm not sure if that's exactly what I have in mind but the idea is to make it work as it is but with an additional logic, when I remove the last layer, I'll apply the new property, if exists (eg. That is a possible property type emptyValue?: string | () => PropValues; In the case of string emptyValue: 'unset', I'll update the style target properties with that value Or I can decide to generate the style properties directly (in case of more advanced usage) emptyValue: () => ({
'background-image': 'unset',
'background-size': 'other value',
// ...
}), |
GrapesJS version
What browser are you using?
Edge last version
Reproducible demo link
https://grapesjs.com/demo
Describe the bug
How to reproduce the bug?
What is the expected behavior?
That editor set header with background:none
What is the current behavior?
GrapesJS inherit from the ‘desktop’ version, so it's impossible to remove background from mobile version.
It happens using 'background' stack version and 'background-image' alone version.
Code of Conduct
The text was updated successfully, but these errors were encountered: