Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Custom block categories can't be named same as prototype object method names or it breaks Grapes #5478

Closed
2 tasks done
bryanjamesmiller opened this issue Oct 21, 2023 · 1 comment

Comments

@bryanjamesmiller
Copy link
Contributor

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome

Reproducible demo link

Version 118.0.5993.88 (Official Build) (arm64)

Describe the bug

How to reproduce the bug?
Video demo part 1:

2023-10-20.23-08-00.online-video-cutter.com.2.mp4

Part 2:

2023-10-20.23-08-00.online-video-cutter.com.3.mp4

Part 3:

2023-10-20.23-08-00.online-video-cutter.com.4.mp4

What is the expected behavior?
Sorry for the 3-part video, it was due to file size restrictions. The expected behavior is i should be able to name my custom block categories anything i want to, such as "constructor", without it breaking grapes.

What is the current behavior?
Currently if you pick any built-in javascript object prototype method name (like "constructor"), then it breaks Grapes JS.

If is necessary to execute some code in order to reproduce the bug, paste it here below:
https://jsfiddle.net/gratiafide/k04azsd9/8/

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bryanjamesmiller bryanjamesmiller changed the title BUG: BUG: Custom block categories can't be named same as prototype object method names or it breaks Grapes Oct 21, 2023
@artf
Copy link
Member

artf commented Nov 1, 2023

Thanks @bryanjamesmiller for all the insights, I'll investigate for a fix.

@artf artf closed this as completed in 561ee08 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants