-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Custom block categories can't be named same as prototype object method names or it breaks Grapes #5478
Closed
2 tasks done
Comments
bryanjamesmiller
changed the title
BUG:
BUG: Custom block categories can't be named same as prototype object method names or it breaks Grapes
Oct 21, 2023
Thanks @bryanjamesmiller for all the insights, I'll investigate for a fix. |
This was referenced May 24, 2024
This was referenced Aug 27, 2024
This was referenced Sep 20, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GrapesJS version
What browser are you using?
Chrome
Reproducible demo link
Version 118.0.5993.88 (Official Build) (arm64)
Describe the bug
How to reproduce the bug?
Video demo part 1:
2023-10-20.23-08-00.online-video-cutter.com.2.mp4
Part 2:
2023-10-20.23-08-00.online-video-cutter.com.3.mp4
Part 3:
2023-10-20.23-08-00.online-video-cutter.com.4.mp4
What is the expected behavior?
Sorry for the 3-part video, it was due to file size restrictions. The expected behavior is i should be able to name my custom block categories anything i want to, such as "constructor", without it breaking grapes.
What is the current behavior?
Currently if you pick any built-in javascript object prototype method name (like "constructor"), then it breaks Grapes JS.
If is necessary to execute some code in order to reproduce the bug, paste it here below:
https://jsfiddle.net/gratiafide/k04azsd9/8/
Code of Conduct
The text was updated successfully, but these errors were encountered: