Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: When add a similar page just components ids will be changed #5425

Closed
2 tasks done
javadsamiee opened this issue Sep 26, 2023 · 1 comment
Closed
2 tasks done

Comments

@javadsamiee
Copy link

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

117

Reproducible demo link

https://jsfiddle.net/mirjavad/ctsx7zer/5/

Describe the bug

I wanted to create a clone action for a page and noticed this bug.

How to reproduce the bug?

  1. Create several pages with the same component ID and CSS

pages: [{ id: 'page-1', name: 'Page 1', component: '<div id="comp1">Page 1</div>', styles: '#comp1 { color: red }', }, { id: 'page-2', name: 'Page 2', component: '<div id="comp1">Page 2</div>', styles: '#comp1 { color: green }', }, { id: 'page-3', name: 'Page 3', component: '<div id="comp1">Page 3</div>', styles: '#comp1 { color: blue }', }]

What is the expected behavior?

For components we should have "comp1", "comp1-2", "comp1-3"
For CSS we should have "#comp1", "#comp1-2", "#comp1-3"

What is the current behavior?

For components the new IDs are correct but all new CSS have "#comp1"

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@artf
Copy link
Member

artf commented Oct 8, 2023

Good catch @javadsamiee will be fixed in the next release

@artf artf closed this as completed in 8c57a5c Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants