Expose fdtransfer, jattach and jcmd and support lib-prefix

Author: marcin-ol

Makefile

@@ -118,7 +118,7 @@ build/%:
 	mkdir -p $@
 
 build/$(LAUNCHER): src/launcher/* src/jattach/* src/fdtransfer.h
-	$(CC) $(CPPFLAGS) $(CFLAGS) -DPROFILER_VERSION=\"$(PROFILER_VERSION)\" -DSUPPRESS_OUTPUT -o $@ src/launcher/*.cpp src/jattach/*.c
+	$(CC) $(CPPFLAGS) $(CFLAGS) -DPROFILER_VERSION=\"$(PROFILER_VERSION)\" -o $@ src/launcher/*.cpp src/jattach/*.c
 	strip $@
 
 PROFILER_FLAGS=-static-libgcc

src/launcher/main.cpp

@@ -51,6 +51,10 @@ static const char USAGE_STRING[] =
     "  list              list profiling events supported by the target JVM\n"
     "  collect           collect profile for the specified period of time\n"
     "                    and then stop (default action)\n"
+    "  fdtransfer        start fdtransfer to serve perf requests on behalf of profiled process\n"
+    "  jattach           invoke jattach directly; requires --jattach-cmd,\n"
+    "                    ignores all arguments except --lib-prefix\n"
+    "\n"
     "Options:\n"
     "  -e event          profiling event: cpu|alloc|lock|cache-misses etc.\n"
     "  -d duration       run profiling for <duration> seconds\n"
@@ -87,6 +91,12 @@ static const char USAGE_STRING[] =
     "  --jfrsync config  synchronize profiler with JFR recording\n"
     "  --fdtransfer      use fdtransfer to serve perf requests\n"
     "                    from the non-privileged target\n"
+    "  --fd-path string  use specified path for fdtransfer to listen at\n"
+    "  --jattach-cmd string\n"
+    "                    arguments to use with jattach action\n"
+    "  -L|--lib-prefix string\n"
+    "                    path prefix to prepend to shared lib\n"
+    "  --fd-path string  socket path for fdtransfer to bind to\n"
     "\n"
     "<pid> is a numeric process ID of the target JVM\n"
     "      or 'jps' keyword to find running JVM automatically\n"
@@ -170,6 +180,10 @@ class String {
         return strcmp(_str, other._str) == 0;
     }
 
+    bool operator!=(const String& other) const {
+        return strcmp(_str, other._str) != 0;
+    }
+
     String& operator<<(const char* tail) {
         size_t len = strlen(_str);
         _str = (char*)realloc(_str, len + strlen(tail) + 1);
@@ -205,7 +219,9 @@ class String {
 
 
 static String action = "collect";
-static const String empty;
+static const String kEmpty;
+static const String kJattachLoad = "load";
+static const String kJattachJcmd = "jcmd";
 static String file, logfile, output, params, format, fdtransfer, libpath;
 static bool use_tmp_file = false;
 static int duration = 60;
@@ -333,38 +349,51 @@ static void run_fdtransfer(int pid, String& fdtransfer) {
     }
 }
 
-static void run_jattach(int pid, String& cmd) {
+static void run_jattach(int pid, const String& verb, String& cmd) {
     pid_t child = fork();
     if (child == -1) {
         error("fork failed", errno);
     }
 
     if (child == 0) {
-        const char* argv[] = {"load", libpath.str(), libpath.str()[0] == '/' ? "true" : "false", cmd.str()};
-        exit(jattach(pid, 4, argv));
+        const char** argv;
+        int argc;
+        int ret;
+        String pidstr;
+        pidstr << pid;
+        if (verb == kJattachLoad) {
+            const char* args[] = {kJattachLoad.str(), libpath.str(), libpath.str()[0] == '/' ? "true" : "false", cmd.str()};
+            ret = jattach(pid, 4, args);
+        } else if (verb == kJattachJcmd) {
+            const char* args[] = {kJattachJcmd.str(), cmd.str()};
+            ret = jattach(pid, 2, args);
+        }
+        exit(ret);
     } else {
         int ret = wait_for_exit(child);
         if (ret != 0) {
             if (WEXITSTATUS(ret) == 255) {
                 fprintf(stderr, "Target JVM failed to load %s\n", libpath.str());
             }
-            print_file(logfile, STDERR_FILENO);
+            if (logfile != kEmpty) print_file(logfile, STDERR_FILENO);
             exit(WEXITSTATUS(ret));
         }
 
-        print_file(logfile, STDERR_FILENO);
+        if (logfile != kEmpty) print_file(logfile, STDERR_FILENO);
         if (use_tmp_file) print_file(file, STDOUT_FILENO);
     }
 }
 
 
 int main(int argc, const char** argv) {
     Args args(argc, argv);
+    String jattach_cmd;
     while (args.hasNext()) {
         String arg = args.next();
 
         if (arg == "start" || arg == "resume" || arg == "stop" || arg == "dump" || arg == "check" ||
-            arg == "status" || arg == "meminfo" || arg == "list" || arg == "collect") {
+            arg == "status" || arg == "meminfo" || arg == "list" || arg == "collect" ||
+            arg == "fdtransfer" || arg == "jattach" || arg == "jcmd") {
             action = arg;
 
         } else if (arg == "-h" || arg == "--help") {
@@ -457,12 +486,20 @@ int main(int argc, const char** argv) {
             params << "," << (arg.str() + 2) << "=" << args.next();
             if (action == "collect") action = "start";
 
+        } else if (arg == "--fd-path") {
+            fdtransfer = String(args.next());
+
         } else if (arg == "--fdtransfer") {
             char buf[64];
-            snprintf(buf, sizeof(buf), "@async-profiler-%d-%08x", getpid(), (unsigned int)time_micros());
-            fdtransfer = buf;
+            if (fdtransfer == kEmpty) {
+                snprintf(buf, sizeof(buf), "@async-profiler-%d-%08x", getpid(), (unsigned int)time_micros());
+                fdtransfer = buf;
+            }
             params << ",fdtransfer=" << fdtransfer;
 
+        } else if (arg == "--jattach-cmd") {
+            jattach_cmd = String(args.next());
+
         } else if (arg.str()[0] >= '0' && arg.str()[0] <= '9' && pid == 0) {
             pid = atoi(arg.str());
 
@@ -489,14 +526,19 @@ int main(int argc, const char** argv) {
         return 1;
     }
 
-    setup_output_files(pid);
-    if (libpath == empty) {
+    if (jattach_cmd == kEmpty) {
+        setup_output_files(pid);
+    } else if (params != kEmpty) {
+        fprintf(stderr, "Warning: --jattach-cmd was given, these parameters will be ignored: %s\n", params.str());
+    }
+
+    if (libpath == kEmpty) {
         setup_lib_path();
     }
 
     if (action == "collect") {
         run_fdtransfer(pid, fdtransfer);
-        run_jattach(pid, String("start,file=") << file << "," << output << format << params << ",log=" << logfile);
+        run_jattach(pid, kJattachLoad, String("start,file=") << file << "," << output << format << params << ",log=" << logfile);
 
         fprintf(stderr, "Profiling for %d seconds\n", duration);
         end_time = time_micros() + duration * 1000000ULL;
@@ -514,10 +556,30 @@ int main(int argc, const char** argv) {
         signal(SIGINT, SIG_DFL);
         fprintf(stderr, "Done\n");
 
-        run_jattach(pid, String("stop,file=") << file << "," << output << format << ",log=" << logfile);
+        run_jattach(pid, kJattachLoad, String("stop,file=") << file << "," << output << format << ",log=" << logfile);
+    } else if (action == "fdtransfer") {
+        if (params != kEmpty) {
+            fprintf(stderr, "Warning: action fdtransfer was given, these parameters will be ignored: %s\n", params.str());
+        }
+        run_fdtransfer(pid, fdtransfer);
+
+    } else if (action == "jattach") {
+        if (jattach_cmd == kEmpty) {
+            fprintf(stderr, "Action jattach was given, missing required --jattach-cmd argument\n");
+            return 1;
+        }
+        run_jattach(pid, kJattachLoad, jattach_cmd);
+
+    } else if (action == "jcmd") {
+        if (jattach_cmd == kEmpty) {
+            fprintf(stderr, "Action jcmd was given, missing required --jattach-cmd argument\n");
+            return 1;
+        }
+        run_jattach(pid, kJattachJcmd, jattach_cmd);
+
     } else {
         if (action == "start" || action == "resume") run_fdtransfer(pid, fdtransfer);
-        run_jattach(pid, String(action) << ",file=" << file << "," << output << format << params << ",log=" << logfile);
+        run_jattach(pid, kJattachLoad, String(action) << ",file=" << file << "," << output << format << params << ",log=" << logfile);
     }
 
     return 0;