[chore] remove useless cast and rename read socket exception

Author: Gr1N

pynats/client.py

@@ -3,24 +3,14 @@
 import re
 import socket
 from dataclasses import dataclass
-from typing import (
-    BinaryIO,
-    Callable,
-    Dict,
-    Match,
-    Optional,
-    Pattern,
-    Tuple,
-    Union,
-    cast,
-)
+from typing import BinaryIO, Callable, Dict, Match, Optional, Pattern, Tuple, Union
 from urllib.parse import urlparse
 
 import pkg_resources
 
 from pynats.exceptions import (
     NATSInvalidResponse,
-    NATSSocketError,
+    NATSReadSocketError,
     NATSUnexpectedResponse,
 )
 from pynats.nuid import NUID
@@ -284,11 +274,10 @@ def _readline(self, *, size: int = None) -> bytes:
         read = io.BytesIO()
 
         while True:
-            raw_bytes = self._socket_file.readline()
-            if not raw_bytes:
-                raise NATSSocketError(b"unable to read from socket")
+            line = self._socket_file.readline()
+            if not line:
+                raise NATSReadSocketError()
 
-            line = cast(bytes, raw_bytes)
             read.write(line)
 
             if size is not None:

pynats/exceptions.py

@@ -1,4 +1,9 @@
-__all__ = ("NATSError", "NATSUnexpectedResponse", "NATSInvalidResponse")
+__all__ = (
+    "NATSError",
+    "NATSUnexpectedResponse",
+    "NATSInvalidResponse",
+    "NATSReadSocketError",
+)
 
 
 class NATSError(Exception):
@@ -17,7 +22,6 @@ def __init__(self, line: bytes, *args, **kwargs) -> None:
         super().__init__()
 
 
-class NATSSocketError(NATSError):
-    def __init__(self, line: bytes, *args, **kwargs) -> None:
-        self.line = line
+class NATSReadSocketError(NATSError):
+    def __init__(self) -> None:
         super().__init__()

tests/test_client.py

@@ -7,7 +7,7 @@
 import pytest
 
 from pynats import NATSClient
-from pynats.exceptions import NATSSocketError
+from pynats.exceptions import NATSReadSocketError
 
 
 @pytest.fixture
@@ -188,7 +188,7 @@ def worker(client, connected_event):
         connected_event.set()
         try:
             client.wait()
-        except NATSSocketError:
+        except NATSReadSocketError:
             assert True
         except Exception:
             raise AssertionError("unexpected Exception raised")