Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Gozala,
I know that this is basically a rewrite of the entire package, but I wanted to see if there is interest in merging this upstream instead of me publishing my own package☺️
The motivation behind this is that I couldn't use the package out of the box since the
module
field points to a file with Flow-typings in it, and thus I cannot consume it without a flow compile step (e.g. via Babel). When I started to fix it I found that the.d.ts
file contained more than just typings, it contained the entire module again, so then I wanted to fix that also. In the end, I found it easier to sort of start from scratch...If you want to, I would be happy if you would like to merge this PR and add me as a maintainer with publishing rights to Npm.
You can also feel free to not merge this, there will be no hard feelings and I'll just publish it under another name!