Development #8
Merged
Development #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2018 11:21
added 3 commits
November 16, 2018 11:30
Update HTTP POST call sample
|
@robincher , please help me review this PR |
|
@kelvinwijaya can help to fix the last comment then i approve |
robincher
reviewed
Dec 7, 2018
|
|
||
| For **formData** parameter used for Signature generation, the key value parameters **do not** need to be URL encoded, | ||
| When your client program is making the actual HTTP POST call, the key value parameters **has** to be URL encoded | ||
|
|
There was a problem hiding this comment.
Can add examples snippet on how both are done?
README.md
Outdated
| con.setReadTimeout(5000); | ||
|
|
||
| DataOutputStream out = new DataOutputStream(con.getOutputStream()); | ||
| ApiList formPostList = new ApiList(); |
There was a problem hiding this comment.
is this formData as mentioned above? Just try to be consistent in the var naming in the README.md
ApiList formData = new ApiList();
There was a problem hiding this comment.
Modified the variable for consistency. Thanks for highlighting
robincher
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update documentation for HTTP form POST (x-www-urlencoded)
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
n/a