Skip to content

Development #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2019
Merged

Development #11

merged 2 commits into from
Mar 22, 2019

Conversation

kelvinwijaya
Copy link
Contributor

Description

Update APISigning class to support non-http standard port

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code enhancement and update (non-breaking change)
  • Security patch

How Has This Been Tested?

Through running test-suites

@kelvinwijaya kelvinwijaya requested a review from robincher March 22, 2019 07:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 71.217% when pulling 45afc34 on development into 96d931e on master.

@kelvinwijaya kelvinwijaya merged commit 235740d into master Mar 22, 2019
GTYeokh pushed a commit that referenced this pull request Dec 17, 2021
@blasttoys
Merge pull request #11 from blasttoys/master
a4c4e91 
Sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincher robincher robincher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinwijaya @coveralls @robincher