Skip to content

Commit e1efbf1

Browse files
author
Morten Barklund
authored
Fixed layer karma tests (#12243)
* Fixed layer karma tests * Fixed another test that referenced the layer panel * Fixed unrelated but annoying flaky test
1 parent 80a5cc6 commit e1efbf1

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

packages/story-editor/src/components/canvas/karma/selection.karma.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ describe('CUJ: Creator can Transform an Element: Selection integration', () => {
121121
await fixture.events.click(layerPanel.togglePanel);
122122
const paragraphLayer = layerPanel.getLayerByInnerText('Fill in some text');
123123
await fixture.events.hover(paragraphLayer);
124-
const lockButton = within(paragraphLayer).getByLabelText('Lock/Unlock');
124+
const lockButton = within(paragraphLayer).getByLabelText(/Lock/);
125125
await fixture.events.click(lockButton);
126126

127127
// Try to click on the text element

packages/story-editor/src/components/floatingMenu/karma/video.karma.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ describe('Video Design Menu: Keyboard Navigation', () => {
5555
20
5656
);
5757

58+
// Escape out of the canvas elements focus trap
59+
await fixture.events.keyboard.press('esc');
60+
5861
await tabToCanvasFocusContainer(focusContainer, fixture);
5962
await fixture.events.keyboard.press('Enter');
6063
await fixture.events.keyboard.press('Tab');

packages/story-editor/src/components/panels/layer/karma/layer.karma.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ describe('Layer Panel', () => {
110110
expect(layerPanel.layers.length).toBe(3);
111111
const elementALayer = layerPanel.getLayerByInnerText('Title 1');
112112
await fixture.events.hover(elementALayer);
113-
const deleteElementAButton = within(elementALayer).getByLabelText('Delete');
113+
const deleteElementAButton = within(elementALayer).getByLabelText(/Delete/);
114114
await fixture.events.click(deleteElementAButton);
115115

116116
expect(layerPanel.layers.length).toBe(2);
@@ -196,7 +196,7 @@ describe('Layer Panel', () => {
196196
const elementALayer = layerPanel.getLayerByInnerText('Title 1');
197197
await fixture.events.hover(elementALayer);
198198
const duplicateElementAButton =
199-
within(elementALayer).getByLabelText('Duplicate');
199+
within(elementALayer).getByLabelText(/Duplicate/);
200200
await fixture.events.click(duplicateElementAButton);
201201

202202
expect(layerPanel.layers.length).toBe(4);
@@ -221,7 +221,7 @@ describe('Layer Panel', () => {
221221

222222
// Hover layer, enable lock, and hover somewhere else
223223
await fixture.events.hover(elementALayer);
224-
const lockButton = within(elementALayer).getByLabelText('Lock/Unlock');
224+
const lockButton = within(elementALayer).getByLabelText(/Lock/);
225225
await fixture.events.click(lockButton);
226226
await fixture.events.hover(elementBLayer);
227227

@@ -236,7 +236,7 @@ describe('Layer Panel', () => {
236236

237237
// Hover layer, disable lock, and hover somewhere else
238238
await fixture.events.hover(elementALayer);
239-
const unlockButton = within(elementALayer).getByLabelText('Lock/Unlock');
239+
const unlockButton = within(elementALayer).getByLabelText(/Unlock/);
240240
await fixture.events.click(unlockButton);
241241
await fixture.events.hover(elementBLayer);
242242

0 commit comments

Comments
 (0)