Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dependencies for kustomize yamls #942

Closed
balopat opened this issue Aug 29, 2018 · 2 comments
Closed

support dependencies for kustomize yamls #942

balopat opened this issue Aug 29, 2018 · 2 comments
Labels
area/deploy deploy/kustomize help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request

Comments

@balopat
Copy link
Contributor

balopat commented Aug 29, 2018

As @mxey pointed out on Slack:

"Skaffold does not support dependencies through Kustomize yet. I only saw this TODO comment https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/deploy/kustomize.go#L92, but there is no issue to track this. Would it make sense to add a command to Kustomize or maybe use Kustomize as a library to list the dependencies, rather than Skaffold interpreting the kustomization itself?"

@r2d4
Copy link
Contributor

r2d4 commented Aug 30, 2018

@nkubala nkubala added the help wanted We would love to have this done, but don't have the bandwidth, need help from contributors label Nov 30, 2018
@dgageot
Copy link
Contributor

dgageot commented Jan 19, 2019

Let's close this one because we do support dependencies now

@dgageot dgageot closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy deploy/kustomize help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request
Projects
None yet
Development

No branches or pull requests

4 participants