Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow templating for requires[].git.repo #8982

Open
camwardy opened this issue Aug 2, 2023 · 1 comment
Open

Allow templating for requires[].git.repo #8982

camwardy opened this issue Aug 2, 2023 · 1 comment
Labels
area/templating kind/todo implementation task/epic for the skaffold team meta/triage priority/p2 May take a couple of releases
Milestone

Comments

@camwardy
Copy link

camwardy commented Aug 2, 2023

Expected behavior

Templating should work for requires[].git.repo. This field doesn't seem to support templating, as outlined in the docs: https://skaffold.dev/docs/environment/templating/. This is required to access a remote private git repository from a CI pipeline.

Actual behavior

Templating does not work for requires[].git.repo

Information

  • Skaffold version: v2.4.0
  • Operating system: Ubuntu 22.04.1
  • Installed via: Standalone binary
  • Contents of skaffold.yaml:
---
apiVersion: skaffold/v4beta4
kind: Config
metadata:
  name: my-config

requires:
  - configs:
      - my-remote-config
    git:
      repo: "https://{{.PAT}}@dev.azure.com/my-org/my-project/_git/my-remote-repo"
      path: skaffold.yaml
      sync: true
      ref: develop

Steps to reproduce the behavior

  1. Store a skaffold config in a remote repository
  2. Run skaffold run -m kafka while passing in a PAT env var for your repo
  3. See that skaffold is not able to resolve the templated value
@aozmen121
Copy link

We've also recently come across this issue, where the requires.repo field doesn't have the ability to template the repo path.

Would anyone point us if this is a known bug? or provide a potential workaround?
@dgageot @tejal29 @balopat @aaron-prindle

@ericzzzzzzz ericzzzzzzz added priority/p2 May take a couple of releases area/templating labels Aug 4, 2023
@ericzzzzzzz ericzzzzzzz added this to the skaffold-backlog milestone Aug 12, 2023
@ericzzzzzzz ericzzzzzzz added the kind/todo implementation task/epic for the skaffold team label Aug 14, 2023
@renzodavid9 renzodavid9 modified the milestones: skaffold-backlog, v2.8.0 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/templating kind/todo implementation task/epic for the skaffold team meta/triage priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

4 participants