Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/grpc-e2e-tests/tests doesn't build from go build . #8474

Open
aaron-prindle opened this issue Feb 23, 2023 · 1 comment
Open

examples/grpc-e2e-tests/tests doesn't build from go build . #8474

aaron-prindle opened this issue Feb 23, 2023 · 1 comment
Labels
kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@aaron-prindle
Copy link
Contributor

Issue tracking that examples/grpc-e2e-tests/tests seems to not build currently:

$ cd examples/grpc-e2e-tests/tests; go build .
client.go:11:2: github.com/GoogleContainerTools/skaffold/examples/grpc-e2e-tests/service@v0.0.0-00010101000000-000000000000: missing go.sum entry; to add it:
    go mod download github.com/GoogleContainerTools/skaffold/examples/grpc-e2e-tests/service
$ go mod tidy                                                        1 ✘  1.19.2  
github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/tests imports
    github.com/GoogleContainerTools/skaffold/v2/examples/grpc-e2e-tests/service/proto: github.com/GoogleContainerTools/skaffold/examples/grpc-e2e-tests/service@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/tests tested by
    github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/tests.test imports
    github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/service/proto: github.com/GoogleContainerTools/skaffold/examples/grpc-e2e-tests/service@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/tests tested by
    github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/tests.test imports
    github.com/onsi/gomega imports
    github.com/onsi/gomega/matchers imports
    gopkg.in/yaml.v3 tested by
    gopkg.in/yaml.v3.test imports
    gopkg.in/check.v1: github.com/GoogleContainerTools/skaffold/examples/grpc-e2e-tests/service@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

NOTE: This is not a huge issue as running skaffold build from examples/grpc-e2e-tests does work as this tests dir is not used. As the tests dir is not used, it might make sense to delete it outright.

Potential Solutions:

  • fix examples/grpc-e2e-tests/tests deps, source, etc. so that go build . works
  • OR remove the examples/grpc-e2e-tests/tests as it is unused with respect to skaffold currently
@aaron-prindle aaron-prindle added priority/p3 agreed that this would be good to have, but no one is available at the moment. kind/todo implementation task/epic for the skaffold team labels Feb 23, 2023
@aaron-prindle
Copy link
Contributor Author

IGNORE: making triage bot happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaron-prindle