Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to add custom labels to kaniko pods #8193

Open
arturs-savickis opened this issue Dec 7, 2022 · 0 comments
Open

Not possible to add custom labels to kaniko pods #8193

arturs-savickis opened this issue Dec 7, 2022 · 0 comments
Labels
build/kaniko kind/bug Something isn't working priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@arturs-savickis
Copy link

skaffold/pkg/skaffold/build/cluster/pod.go

Line 56 in 88a27ab

Labels: map[string]string{"skaffold-kaniko": "skaffold-kaniko"},

We are using AKS + ACR with managed identity, so in order to allow pods to access ACR we mark them with label "aad-pod-identity: <some_value>", since kaniko pods doesn't allow to set custom labels we are not able to use images from our custom registry.

Current behavior: Kaniko pod labels are always set to "skaffold-kaniko"
Expected behavior: it is possible to pass custom labels to kaniko pods
@aaron-prindle aaron-prindle added kind/bug Something isn't working priority/p3 agreed that this would be good to have, but no one is available at the moment. priority/p0 Highest priority. We are actively looking at delivering it. priority/p2 May take a couple of releases build/kaniko and removed priority/p0 Highest priority. We are actively looking at delivering it. priority/p2 May take a couple of releases priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Dec 22, 2022
@renzodavid9 renzodavid9 added priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p2 May take a couple of releases labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build/kaniko kind/bug Something isn't working priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaron-prindle @renzodavid9 @arturs-savickis