Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate additional skaffold fix changes related to render hooks #7803

Open
aaron-prindle opened this issue Aug 24, 2022 · 0 comments
Open
Labels

Comments

@aaron-prindle
Copy link
Contributor

Currently v1 Deploy Lifecycle hooks are moved to the Deploy phase in the v2 schema but this might not be the place for a 1:1 translation given v2 splits Deploy -> Render + Deploy. We should investigate if pre-deploy hooks would be better translated to pre-render hooks or at least output some warning/message stating that a pre-deploy hooks was found and there is some ambiguity

@aaron-prindle aaron-prindle added kind/feature-request priority/p2 May take a couple of releases area/hooks 2.0.0 Issues related to the 2.0.0 release labels Aug 24, 2022
@aaron-prindle aaron-prindle added this to the skaffold-v2-backlog milestone Oct 17, 2022
@aaron-prindle aaron-prindle removed the 2.0.0 Issues related to the 2.0.0 release label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant