Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for Helm artifactsOverride by using Skaffold as a post-renderer #6706

Open
2 of 3 tasks
briandealwis opened this issue Oct 7, 2021 · 4 comments
Open
2 of 3 tasks
Labels
area/deploy deploy/helm kind/feature-request kind/friction Issues causing user pain that do not have a workaround planning/Q4-21 Q4 2021 planning priority/p1 High impact feature/bug.

Comments

@briandealwis
Copy link
Member

briandealwis commented Oct 7, 2021

Helm 3.1 supports specifying a post-renderer, a simple filter that is afforded an opportunity to alter the rendered manifests prior to being applied to the cluster. We use the post-renderer to support skaffold debug with Helm (#4732). We should use the post-renderer as part of the helm install and helm upgrade to perform our manifest transformations more generally and thus side-step the need for artifactsOverride and our separate labelling step. This change would greatly simplify configuration of Helm projects as well as avoiding resource churn (e.g., setting a label on a deployments will re-create its pods; #3133).

This change will require moving our minimum supported Helm version to 3.1.0.

@briandealwis briandealwis added kind/feature-request area/deploy deploy/helm priority/p1 High impact feature/bug. kind/friction Issues causing user pain that do not have a workaround labels Oct 7, 2021
@briandealwis briandealwis self-assigned this Oct 8, 2021
@briandealwis briandealwis added this to the v1.34.0 milestone Oct 8, 2021
@tejal29 tejal29 added the planning/Q4-21 Q4 2021 planning label Oct 13, 2021
@tejal29 tejal29 modified the milestones: unplanned, v1.35.0 Oct 13, 2021
@tejal29
Copy link
Member

tejal29 commented Nov 15, 2021

@briandealwis are you planning to get this in ?

@nkubala nkubala modified the milestones: v1.35.0, 2.0.0-alpha Nov 15, 2021
@briandealwis
Copy link
Member Author

Yes. Hit some stumbling blocks with testing.

@tejal29
Copy link
Member

tejal29 commented Mar 31, 2022

@briandealwis Is this done on v2?

@briandealwis
Copy link
Member Author

#6951 and #6952 are still outstanding

@aaron-prindle aaron-prindle removed their assignment Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy deploy/helm kind/feature-request kind/friction Issues causing user pain that do not have a workaround planning/Q4-21 Q4 2021 planning priority/p1 High impact feature/bug.
Projects
None yet
Development

No branches or pull requests

4 participants