Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option to suppress output from hooks runner #6344

Open
nkubala opened this issue Aug 2, 2021 · 1 comment
Open

Expose option to suppress output from hooks runner #6344

nkubala opened this issue Aug 2, 2021 · 1 comment
Labels
area/hooks help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@nkubala
Copy link
Contributor

nkubala commented Aug 2, 2021

From #6337 (comment):

we definitely can't use the deploy mute setting since the application logs are manually muted in-between dev loops using this setting. This will have the effect of never actually printing the container hook log messages, since the container hooks are always executed in-between dev loops.

As is, output from executing hooks scripts will always be surfaced to users, even when the logs for individual phases are suppressed. We should either:

  • tie the output of the hooks to the associated phase (e.g. pre-/post-deploy hooks tied to the deploy phase; or,
  • add an option to explicitly suppress output from hooks themselves, independent of their associated phase

Option 1 seems a bit cleaner, but Option 2 seems useful for users who have hooks with particularly verbose output.

@nkubala nkubala added kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. area/hooks labels Aug 2, 2021
@verbanicm verbanicm self-assigned this Sep 9, 2021
@verbanicm verbanicm added this to the v1.33.0 milestone Sep 15, 2021
@tejal29 tejal29 modified the milestones: v1.33.0, v1.34.0 Oct 8, 2021
@tejal29 tejal29 added the help wanted We would love to have this done, but don't have the bandwidth, need help from contributors label Oct 14, 2021
@tejal29
Copy link
Contributor

tejal29 commented Mar 22, 2022

Making TP happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hooks help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

3 participants