Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold init --analyze --compose-file docker-compose.yaml writes k8s yaml files #6251

Open
j-windsor opened this issue Jul 20, 2021 · 3 comments
Labels
area/init area/init-analyze kind/bug Something isn't working planning/Q4-21 Q4 2021 planning priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@j-windsor
Copy link

Expected behavior

Typically, the --analyze flag does not actually commit anything to the filesystem. The same thing should occur here. The stdout output looks good and should remain the same.

Actual behavior

kompose runs and outputs yaml files to the cwd in addition to outputting the correct stdout contents.
Screen Shot 2021-07-19 at 4 59 33 PM

Information

  • Skaffold version: v1.27.0
  • Operating system: MacOS Big Sur 11.4
  • Installed via: Google Cloud SDK
  • Contents of skaffold.yaml: n/a

Steps to reproduce the behavior

  1. Clone https://github.com/docker/awesome-compose/tree/master/nginx-flask-mongo
  2. skaffold init --analyze --compose-file docker-compose.yaml
@MarlonGamez
Copy link
Contributor

Left a similar comment on #6249, but it's clear we have some untangling that needs to happen with our flag features. I'll be looking into these

@tejal29 tejal29 added planning/Q3-21 priority/p1 High impact feature/bug. and removed priority/p2 May take a couple of releases labels Aug 13, 2021
@sivakku sivakku added priority/p2 May take a couple of releases and removed priority/p1 High impact feature/bug. labels Aug 17, 2021
@sivakku
Copy link

sivakku commented Aug 17, 2021

Marking it to P2 since we are not focusing on Kompose for Next.

@tejal29 tejal29 added planning/Q4-21 Q4 2021 planning and removed planning/Q3-21 labels Sep 13, 2021
@MarlonGamez MarlonGamez added priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p2 May take a couple of releases labels Nov 1, 2021
@MarlonGamez
Copy link
Contributor

hi @sivakku, are there plans to prioritize this any time in the future? If not, I think I'll close this issue.

For now I'm going to just bump down the priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init area/init-analyze kind/bug Something isn't working planning/Q4-21 Q4 2021 planning priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

4 participants