Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker builder should support separate dockerfiles for dev and debug #5844

Open
briandealwis opened this issue May 13, 2021 · 2 comments
Open

Comments

@briandealwis
Copy link
Member

Users expect that skaffold dev and skaffold debug with file-sync will ✨magically✨ rebuild or relaunch their applications built using the Docker builder.

Although we do expose the SKAFFOLD_RUN_MODE as a build argument for docker builds, it is difficult to craft a Dockerfile rules to take advantage of it.

I can see two approaches:

  1. Use the specified dockerfile and see if there is a ${dockerfile}.${runMode} (e.g.,Dockerfile.dev or Dockerfile.debug). But it's impossible for the user to override.
  2. Allow the dockerfile to be templated so that they can incorporate the SKAFFOLD_RUN_MODE environment variable.
  3. Extend the docker: definition to allow specifying separate devDockerfile and debugDockerfile items.
@tejal29 tejal29 added priority/p1 High impact feature/bug. priority/p2 May take a couple of releases and removed priority/p1 High impact feature/bug. labels May 17, 2021
@tejal29
Copy link
Member

tejal29 commented May 17, 2021

adding p2 priority, unless @briandealwis you know this is higher priority.

@briandealwis
Copy link
Member Author

p2 sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants