Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold find-configs should error if a too-new config file is found #5544

Open
briandealwis opened this issue Mar 12, 2021 · 0 comments
Open
Labels
area/config kind/friction Issues causing user pain that do not have a workaround priority/p2 May take a couple of releases

Comments

@briandealwis
Copy link
Member

I tried to launch the examples/helm-deployment within CC-VSC, which failed in a surprising way. In diagnosing the issue, it turns out that I was actually in integration/examples/helm-deployment and the skaffold.yaml had too new of an apiVersion. CC uses skaffold find-configs to find the configuration files, which in this case returns nothing:

$ skaffold version
v1.20.0
$ skaffold find-configs --output json
{}

As a result, CC-VSC then tried to do a skaffold init --analyze, which failed (due to Helm).

Expected behavior

skaffold find-configs should probably report all skaffold.yaml regardless of the apiVersion. It's possible a user is running an older version of Skaffold. Let the version error come up when they attempt to launch.

Information

@briandealwis briandealwis added area/config priority/p2 May take a couple of releases kind/friction Issues causing user pain that do not have a workaround labels Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/friction Issues causing user pain that do not have a workaround priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

1 participant