Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not adding Skaffold labels by default in render #5542

Closed
nkubala opened this issue Mar 12, 2021 · 0 comments · Fixed by #5653
Closed

Consider not adding Skaffold labels by default in render #5542

nkubala opened this issue Mar 12, 2021 · 0 comments · Fixed by #5653
Assignees
Labels
area/labels area/render kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Milestone

Comments

@nkubala
Copy link
Contributor

nkubala commented Mar 12, 2021

With the addition of skaffold apply, we will be applying the skaffold.dev/run-id and kubernetes.io/managed-by labels by default when resources are actuated to the cluster, meaning they're not required in the hydrated manifests provided for functionality like status check to work.

These labels are added by default to all manifests rendered through skaffold render, but given that skaffold apply can consume skaffold render's output and adds these labels, we might want to just default to not adding them in render to clean up the hydrated manifests we output. The labels themselves are an implementation detail for our status check and don't provide any value to users.

➜  (getting-started) skaffold render
apiVersion: v1
kind: Pod
metadata:
  labels: <-- these labels provide no value to users
    app.kubernetes.io/managed-by: skaffold
    skaffold.dev/run-id: bd0e8bf3-dc76-40c6-900c-dc2754eb883c
  name: getting-started
  namespace: default
spec:
  containers:
  - image: skaffold-example:99e5f4d45e86d2aa180ebb6d382015d43383fef1ed7efcfff1a61fd205421479
    name: getting-started


➜  (getting-started) skaffold render --add-skaffold-labels=false
apiVersion: v1
kind: Pod
metadata:
  name: getting-started
  namespace: default
spec:
  containers:
  - image: skaffold-example:99e5f4d45e86d2aa180ebb6d382015d43383fef1ed7efcfff1a61fd205421479
    name: getting-started
@nkubala nkubala added kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. area/labels area/render labels Mar 12, 2021
@nkubala nkubala added this to the v1.22.0 milestone Mar 22, 2021
@nkubala nkubala self-assigned this Mar 22, 2021
@nkubala nkubala modified the milestones: v1.22.0, v1.24.0 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/labels area/render kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
1 participant