Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dev's fail on first build and deploy be configurable #4953

Closed
briandealwis opened this issue Oct 27, 2020 · 2 comments
Closed

Make dev's fail on first build and deploy be configurable #4953

briandealwis opened this issue Oct 27, 2020 · 2 comments
Labels
area/config kind/feature-request kind/friction Issues causing user pain that do not have a workaround

Comments

@briandealwis
Copy link
Member

From Tais P. Hansen on skaffold-users@:

I have a simple setup with a deployment of the service being developed and a deployment with a backend store. The service won't start as long as it can't connect to the backend store service which takes a few seconds to start. Kubernetes normally just restarts the pod until it connects and runs but skaffold tears everything down on the first exit, making it impossible to use "skaffold dev" without having to add connection retry logic to the service itself.
...
Using an init container may be a viable workaround but I was trying to avoid having to create such workarounds just because of the behaviour of a development tool in the first place. I was hoping for some setting or parameter I had overlooked somewhere.

We've discussed this previously, and it does seem like this should be configurable behaviour.

@briandealwis briandealwis added kind/feature-request area/config kind/friction Issues causing user pain that do not have a workaround labels Oct 27, 2020
@tejal29
Copy link
Contributor

tejal29 commented Oct 27, 2020

@balopat and me had briefly discussed this #4158 during cloud run skaffold integration. We also tried it out in our long working prototype branch.

I was also thinking this could be useful for increasing the skaffold session success rate especially for BUILD compilation errors.

@tejal29
Copy link
Contributor

tejal29 commented Oct 27, 2020

@briandealwis I am moving the discussion to #4158 and close this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/feature-request kind/friction Issues causing user pain that do not have a workaround
Projects
None yet
Development

No branches or pull requests

2 participants