Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache should detect locally built image with different name when push fails #4818

Open
nkubala opened this issue Sep 23, 2020 · 1 comment
Open

Comments

@nkubala
Copy link
Contributor

nkubala commented Sep 23, 2020

a common build failure scenario is forgetting to apply a default repo, meaning that images build fine but skaffold will fail because of a failed push. once a default repo is applied, the subsequent build and push will succeed, but rebuilds shouldn't be necessary if the previous build succeeded. however, skaffold's cache check is naive in checking for a direct image name match, and will fail and rebuild, which can be annoying with long image builds.

Expected behavior

after successful build but failed push, subsequent build/push should detect image built locally if name changes (but tag stays the same)

Actual behavior

cache check fails because image name has changed

Information

  • Skaffold version: v1.14.0
  • Operating system: all

Steps to reproduce the behavior

  1. https://github.com/GoogleCloudPlatform/bank-of-anthos
  2. skaffold build # build with succeed, but push will fail
  3. skaffold build -d <repo_with_push_access>
@tejal29
Copy link
Member

tejal29 commented Mar 22, 2022

Making TP happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants