Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parent/child "module" spec inlined in a single skaffold.yaml #4457

Closed
nkubala opened this issue Jul 9, 2020 · 2 comments
Closed
Assignees
Labels
area/modules kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@nkubala
Copy link
Contributor

nkubala commented Jul 9, 2020

We should add support for specifying child modules of a parent within one skaffold.yaml.

From https://tinyurl.com/skaffold-modules:

apiVersion: skaffold/v2beta2
kind: Config
metadata:
 name: microservices
modules:
 - name: leeroy-web
   build:
     artifacts:
       - image: leeroy-web
         context: ./leeroy-web/
         requires:
           - alias: BASE
             image: simple-go-app
             module:
               name: base
   deploy:
     kubectl:
       manifests:
         - ./leeroy-web/kubernetes/*
   portForward:
     - resourceType: deployment
       resourceName: leeroy-web
       port: 8080
       localPort: 9000
 - name: leeroy-app
   build:
     artifacts:
       - image: leeroy-app
         context: ./leeroy-app/
         requires:
           - alias: BASE
             image: simple-go-app
             module:
               name: base
   deploy:
     kubectl:
       manifests:
         - ./leeroy-app/kubernetes/*
 - name: base
   build:
     artifacts:
       - image: simple-go-app
         context: base
@nkubala nkubala added kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it. area/modules labels Jul 9, 2020
@nkubala nkubala added this to the v1.13.0 milestone Jul 9, 2020
@nkubala nkubala modified the milestones: v1.13.0, v1.15.0 Aug 11, 2020
@gsquared94
Copy link
Collaborator

I'll get started on this.

@gsquared94
Copy link
Collaborator

Closing as obsolete. Equivalent feature implemented via config dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modules kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

No branches or pull requests

3 participants