Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting labels in skaffold render #3482

Closed
nkubala opened this issue Jan 8, 2020 · 0 comments · Fixed by #3558
Closed

Support setting labels in skaffold render #3482

nkubala opened this issue Jan 8, 2020 · 0 comments · Fixed by #3558

Comments

@nkubala
Copy link
Contributor

nkubala commented Jan 8, 2020

when deploying with kubectl or kustomize, currently the manifests are rendered using renderManifests, and then labels are set in the manifests after they're rendered. this same function is used for skaffold render, meaning that labels are not set in the final rendered manifests and don't match up to the manifests that are actually sent through to be deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant