-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"skaffold init" generates incorrect config for Jib project #2844
Comments
Ah, I think I see the issue. In
i.e. if the goal is running on the root project, don't provide the module name to skaffold. The problem is that a spring initializr project is not actually the root project. In the demo project's pom.xml:
So, it seems we need to find a different way of determining whether or not a module is the root project on the Jib side of things. |
Alternatively, I think we could fix this skaffold-side by just checking the number of modules that were output by Jib, and ignore the project if it's only one. |
This will be fixed in the next release of Jib. |
In #2843, the config for a Jib project has
module: demo
However, the project was a simple Spring Boot demo generated from the Initializr and not a multi-module project. I had to remove
module:
to make it work correctly. Seems like a bug.@GoogleContainerTools/java-tools-build
The text was updated successfully, but these errors were encountered: