Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of cluster builder namespace from flag #2757

Open
balopat opened this issue Aug 29, 2019 · 2 comments
Open

Allow override of cluster builder namespace from flag #2757

balopat opened this issue Aug 29, 2019 · 2 comments
Labels
area/build build/kaniko kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@balopat
Copy link
Contributor

balopat commented Aug 29, 2019

Kaniko pods are always executed in build.cluster.namespace. This made integration testing awkward in #2734 (comment) - skaffold build -n <namespace> should honor the namespace setting, but maybe we need a separate flag for that - build-namespace. We should think through the implications.

@nkubala nkubala added priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p1 High impact feature/bug. labels Apr 30, 2020
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@andrskom
Copy link

andrskom commented Feb 6, 2021

Hi! I would like to help with this issue.
What is the best way in your opinion, should I use Namespace from SkaffoldOptions struct or create a new option.

The second one looks better in my opinion, because we can separate the process of the building and the process of the deployment.

Please let me know your decision.

@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
@briandealwis
Copy link
Member

@andrskom we missed your reply. If you're still interested, I think @balopat's approach of creating a new BuildNamespace field in the SkaffoldOptions is still best as using the Namespace could result in confusion with skaffold dev where we both build and deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build/kaniko kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

4 participants