Add fake.Cache.RemoveInformer #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method is required to satisfy the Informers interface in new versions of controller-runtime. It allows removing and stopping an informer from a set of informers. The individual informers are stopped using informer-specific context wrappers with cancel funcs. This blocks upgrading our controller-runitme dependency.
Merged
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
google-oss-prow
bot
merged commit ffbebed
into
GoogleContainerTools:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method is required to satisfy the Informers interface in new versions of controller-runtime. It allows removing and stopping an informer from a set of informers. The individual informers are stopped using informer-specific context wrappers with cancel funcs.
This blocks upgrading our controller-runitme dependency.
Ref: kubernetes-sigs/controller-runtime#2285