Redundant snapshot with --use-new-run #2800
Labels
area/snapshotting
feat/use-new-run
kind/bug
Something isn't working
priority/p2
High impact feature/bug. Will get a lot of users happy
Milestone
Actual behavior
When I pass
--use-new-run
I see the following toward the end of the logs:But I am not sure why a snapshot would be required, or if it makes sense that the behavior differs when running without
--use-new-run
.Expected behavior
I would expect not to see any snapshotting. There is no snapshot if I omit
--use-new-run
. In some cases we are seeing a pretty long delay for the snapshot (12 seconds in one case) so avoiding it would speed up our builds.To Reproduce
FROM codercom/oss-dogfood
(or any other image, I believe).Additional Information
I can prevent the snapshot by removing the
s.opts.RunV2
check found here:kaniko/pkg/executor/build.go
Line 347 in b6f14ae
However, I am unsure if there are negative consequences to doing so. I see the commit that added the check but it did not shed any light for me.
I tested my own build and ran
go test
without seeing any related issues though.If this does seem like something that can be removed, please let me know if it would be helpful for me to send a PR or if this is tiny enough that it is easier for someone else to just push it.
Triage Notes for the Maintainers
--cache
flagThank you!
The text was updated successfully, but these errors were encountered: