Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.1 #2028

Closed
imjasonh opened this issue Apr 1, 2022 · 5 comments
Closed

Release v1.8.1 #2028

imjasonh opened this issue Apr 1, 2022 · 5 comments
Assignees

Comments

@imjasonh
Copy link
Collaborator

imjasonh commented Apr 1, 2022

Notable changes since v1.8.1:

All changes: v1.8.0...main

There may also be some auth issues (#1821) but I probably won't have time to dig into them immediately, and the fixes above seem worth releasing.

@chuangw6
Copy link
Contributor

chuangw6 commented Apr 1, 2022

Thanks @imjasonh! Thanks to all contributors on this v1.8.1 release!
#2029

@hojo0590
Copy link

hojo0590 commented Apr 5, 2022

Will there be a v1.8.1-debug tag too? Currently there is only debug.
I'd like to test upgrading an image in a CI pipeline but in a safe way.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Apr 5, 2022

Will there be a v1.8.1-debug tag too? Currently there is only debug. I'd like to test upgrading an image in a CI pipeline but in a safe way.

It looks like the release workflow tagged the debug image as :v1.8.1 instead of as :v1.8.1-debug, based on logs here: https://github.com/GoogleContainerTools/kaniko/runs/5833880413?check_suite_focus=true#step:11:8

This was supposed to take the other branch, based on if [[ debug -eq "latest"]], but for some reason took the branch that tags the image as :v1.8.1. 🤔

The :slim image did the same thing, tagging as :v1.8.1 instead of :v1.8.1-slim: https://github.com/GoogleContainerTools/kaniko/runs/5833880816?check_suite_focus=true#step:11:8

The :latest image correctly points to :v1.8.1 at least, so that's unaffected.

It looks like we need to do some manual intervention, and fix the release workflow for future releases.

crane cp gcr.io/kaniko-project/executor@sha256:3bc3f3a05f803cac29164ce12617a7be64931748c944f6c419565f500b65e8db gcr.io/kaniko-project/executor:v1.8.1-debug

crane cp gcr.io/kaniko-project/executor@sha256:befa11c3531a8c4dab403250c4ce8d770a6b3097054a7d924802d340e687851c gcr.io/kaniko-project/executor:v1.8.1-slim

@chuangw6
Copy link
Contributor

chuangw6 commented Apr 5, 2022

Thanks for pointing out this. @hojo0590
For v1.8.1, I've manually added v1.8.1-debug and v1.8.1-slim. Please try pull with new tags.

Thanks @imjasonh for fixing this in release tagging workflow for future releases.

@hojo0590
Copy link

hojo0590 commented Apr 6, 2022

Thanks for pointing out this. @hojo0590 For v1.8.1, I've manually added v1.8.1-debug and v1.8.1-slim. Please try pull with new tags.

Thanks @imjasonh for fixing this in release tagging workflow for future releases.

Thank you for fixing the tags. Pulling the v1.8.1 debug is now possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants