Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom assertion failure output for FileEntry in LayersTest #2725

Open
chanseokoh opened this issue Aug 25, 2020 · 0 comments
Open

Remove custom assertion failure output for FileEntry in LayersTest #2725

chanseokoh opened this issue Aug 25, 2020 · 0 comments

Comments

@chanseokoh
Copy link
Member

We implemented FileEntry.toString() and FilePermissions.toString() in #2714. After a new jib-build-plan is released, remove the custom FileEntry output code in LayersTest.

try {
Assert.assertEquals(expectedLayerEntries, ImmutableSet.copyOf(layer.getEntries()));
} catch (AssertionError ae) {
System.out.println("ACTUAL");
layer
.getEntries()
.forEach(
entry -> {
System.out.println("src: " + entry.getSourceFile());
System.out.println("dest: " + entry.getExtractionPath());
System.out.println("permission: " + entry.getPermissions().toOctalString());
System.out.println("time: " + entry.getModificationTime());
System.out.println("ownership: " + entry.getOwnership());
});
System.out.println("EXCPECTED");
expectedLayerEntries.forEach(
entry -> {
System.out.println("src: " + entry.getSourceFile());
System.out.println("dest: " + entry.getExtractionPath());
System.out.println("permission: " + entry.getPermissions().toOctalString());
System.out.println("time: " + entry.getModificationTime());
System.out.println("ownership: " + entry.getOwnership());
});
throw ae;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants