Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute ContainerBuildPlan for ContainerConfiguration and JibContainerBuilder.layerConfigurations #2625

Open
chanseokoh opened this issue Jul 24, 2020 · 0 comments

Comments

@chanseokoh
Copy link
Member

chanseokoh commented Jul 24, 2020

As mentioned in JibContainerBuilder.

  private final ContainerBuildPlan.Builder containerBuildPlanBuilder = ContainerBuildPlan.builder();
  // TODO(chanseok): remove and use containerBuildPlanBuilder instead. Note that
  // ContainerConfiguation implements equals() and hashCode(), so need to verify
  // if they are required.
  private final ContainerConfiguration.Builder containerConfigurationBuilder =
      ContainerConfiguration.builder();

The two classes are basically identical. As of now, JibContainerBuilder is using both (i.e., duplicating configuration in each class): ContainerConfiguration for internal and historical use with the jib-core backend code, and ContainerBuildPlan for public API.

layerConfigurations can be removed too.

  // TODO(chanseok): remove and use containerBuildPlanBuilder instead.
  private List<FileEntriesLayer> layerConfigurations = new ArrayList<>();
@chanseokoh chanseokoh changed the title Replace ContainerConfiguration with ContainerBuildPlan Substitute ContainerBuildPlan for ContainerConfiguration and JibContainerBuilder.layerConfigurations Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants