NPE when adding LayerEntry relative to the root '/'

[briandealwis]

Environment:

• Jib version: jib-core 0.12.0
• Build tool: cram
• OS: macOS

Description of the issue:

Seeing NPEs when using jib-core to create a layer with content placed at "/":

Caused by: java.lang.NullPointerException
	at com.google.cloud.tools.jib.image.ReproducibleLayerBuilder$UniqueTarArchiveEntries.add(ReproducibleLayerBuilder.java:75)
	at com.google.cloud.tools.jib.image.ReproducibleLayerBuilder$UniqueTarArchiveEntries.access$100(ReproducibleLayerBuilder.java:47)
	at com.google.cloud.tools.jib.image.ReproducibleLayerBuilder.build(ReproducibleLayerBuilder.java:118)
	at com.google.cloud.tools.jib.builder.steps.BuildAndCacheApplicationLayerStep.call(BuildAndCacheApplicationLayerStep.java:107)
	at com.google.cloud.tools.jib.builder.steps.BuildAndCacheApplicationLayerStep.call(BuildAndCacheApplicationLayerStep.java:37)
	... 6 more

The code in question:

jib/jib-core/src/main/java/com/google/cloud/tools/jib/image/ReproducibleLayerBuilder.java

Lines 73 to 76 in a692b8b

	Path namePath = Paths.get(tarArchiveEntry.getName());
	if (namePath.getParent() != namePath.getRoot()) {
	TarArchiveEntry dir = new TarArchiveEntry(DIRECTORY_FILE, namePath.getParent().toString());
	dir.setModTime(LayerConfiguration.DEFAULT_MODIFICATION_TIME.toEpochMilli());

The layer configurations had been built with LayerConfiguration.Builder.addEntryRecursive()

In this case, tarEntryPath.getName() is / (the root directory). namePath is a sun.nio.fs.UnixPath on "/" with filesystem of type sun.nio.fs.MacOSXFileSystem. But namePath.getParent() returns null, which adheres to the contract of Path#getParent(): Returns the parent path, or null if this path does not have a parent.

So an obvious fix is to change this guard to

 if (namePath.getParent() == null || namePath.getParent() != namePath.getRoot()) {

But should we be adding a tar entry for the root directory?

[briandealwis]

Reproducible with java -jar cram-xxx.jar --docker gcr.io/distroless/static image target where target is a directory. This causes target to be placed in /. Specifying target:/path works as /path's parent is not null.

[TadCordle]

I don't think there's any harm in having an explicit entry for /, is there? Maybe we can just go with the quick fix you suggested.

[loosebazooka]

Lets not generate this entry: / for now.

[wilx]

Adding a directory into "/" was the first thing I tried. It would be nice if this worked.