jib-maven-plugin is hardcoding the webappDirectory path for war plugins

[susp248]

Description of the issue:
The current implementation is assuming that the web app is always residing in ${project.build.directory}/${project.build.finalName} which is only the default value.

This path is actually configurable per configuration parameter so jib should not rely on this.

Steps to reproduce:
Specify a configuration parameter in the maven-war-plugin.

Expected behavior:

The should be made configurable in the jib-configuration.

Environment: Maven

Additional Information:

[chanseokoh]

Hi @susp248,

Thanks for opening the issue. We're aware that the WAR (and the exploded WAR) path is configurable with maven-war-plugin and have left the comment in the code.

    // TODO explode the WAR file rather than using this directory. The contents of the final WAR may
    // be different from this directory (it's possible to include or exclude files when packaging a
    // WAR). Also the exploded WAR directory is configurable with <webappDirectory> and may not be
    // at build.getFinalName().

The should be made configurable in the jib-configuration.

However, I don't think this should be made configurable in Jib. Jib can get the value from maven-war-plugin, so no need to make it configurable on the Jib side.

[chanseokoh]

When we unpack the WAR (#1091), for the final WAR file location, maybe we should read <outputDirectory> (which defaults to target/) instead of <webappDirectory>.