Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude profiler from 3.11 (unsupported version) #9377

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Conversation

kweinmeister
Copy link
Contributor

Per GoogleCloudPlatform/cloud-profiler-python#133, 3.11 is not currently supported. These samples are failing in the nightly build.

This PR excludes profiler from being tested on 3.11. Also, there is a 3.7 focused sample in the group that I've limited the testing to 3.7 only.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Mar 26, 2023
@kweinmeister kweinmeister added the snippet-bot:force-run Force snippet-bot runs its logic label Mar 26, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Mar 26, 2023
@kweinmeister kweinmeister marked this pull request as ready for review March 26, 2023 15:03
@kweinmeister kweinmeister requested a review from a team as a code owner March 26, 2023 15:03
kweinmeister and others added 4 commits March 29, 2023 09:39
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2023
# https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py

TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# You can opt out from the test for specific Python versions.
# You can opt out from the test for specific Python versions.
# 3.7 is the only supported version

@leahecole leahecole merged commit 64c1efa into main Mar 29, 2023
@leahecole leahecole deleted the 311-profiler branch March 29, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants