-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: exclude profiler from 3.11 (unsupported version) #9377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
Issues that are directly related to samples.
api: appengine
Issues related to the App Engine Admin API API.
labels
Mar 26, 2023
snippet-bot
bot
removed
the
snippet-bot:force-run
Force snippet-bot runs its logic
label
Mar 26, 2023
Mariatta
reviewed
Mar 29, 2023
leahecole
reviewed
Mar 29, 2023
Mariatta
reviewed
Mar 29, 2023
Mariatta
reviewed
Mar 29, 2023
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Mariatta
approved these changes
Mar 29, 2023
kweinmeister
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 29, 2023
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 29, 2023
leahecole
approved these changes
Mar 29, 2023
# https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/noxfile_config.py | ||
|
||
TEST_CONFIG_OVERRIDE = { | ||
# You can opt out from the test for specific Python versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# You can opt out from the test for specific Python versions. | |
# You can opt out from the test for specific Python versions. | |
# 3.7 is the only supported version |
leahecole
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: appengine
Issues related to the App Engine Admin API API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per GoogleCloudPlatform/cloud-profiler-python#133, 3.11 is not currently supported. These samples are failing in the nightly build.
This PR excludes profiler from being tested on 3.11. Also, there is a 3.7 focused sample in the group that I've limited the testing to 3.7 only.