chore(speech): migrate code from googleapis/python-speech #8982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie385fd8105325c6f2754b737e0f11c84254bcb47
* Migrate quickstart to GAPIC client library * Migrate transcribe to GAPIC client library * Migrate transcribe_async to GAPIC client library * Migrate transcribe_streaming to GAPIC client library * clean up * clean up * Import from google.cloud.speech * update transcribe samples * import in alphabetic order * remove unused variable * use strings instead of enums * restructure code * comment on sreaming requests * import style * flake * correct indent * migrate transcribe_streaming_mic to gapic * update google-cloud-speech version requirement * addressing review comments * at the end of the audio stream, put None to signal to the generator * flake * addressing github review comments * add region tags for migration guide * update README * rst format * bullet * addressing PR review comments * use enums * remove a word
* Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
|
Here is the summary of changes. You are about to add 53 region tags.
This comment is generated by snippet-bot.
|
nicain
approved these changes
Jan 24, 2023
|
@telpirion Should we include the CODEOWNERS and blunderbuss.yml updates, too? @nicain @m-strzelczyk @dandhlee These changes are blocked by an invalid license header, "Google Inc" rather than "Google, Inc." Given that these are existing files, should we update the configuration to allow "Google Inc" or do you have another suggestion to move forward? |
|
We should fix the license headers, if they're deemed invalid (slight tweak to fix them is fine). |
dandhlee
requested changes
Feb 3, 2023
speech/snippets/transcribe_streaming_voice_activity_timeouts.py
Outdated
Show resolved
Hide resolved
speech/snippets/transcribe_streaming_voice_activity_timeouts_test.py
Outdated
Show resolved
Hide resolved
dandhlee
approved these changes
Feb 8, 2023
|
Thank you, @dandhlee ! |
|
Seems like tests are passing now! I don't anticipate 3.9 failing for a different reason. Overriding CLA and admin merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)