Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appengine/standard_python3): print gcloud cmds to improve debugging #8561

Merged
merged 4 commits into from
Nov 30, 2022
Merged

feat(appengine/standard_python3): print gcloud cmds to improve debugging #8561

merged 4 commits into from
Nov 30, 2022

Conversation

ace-n
Copy link

@ace-n ace-n commented Nov 29, 2022

No description provided.

@ace-n ace-n requested a review from engelke November 29, 2022 21:16
@ace-n ace-n requested review from a team as code owners November 29, 2022 21:16
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 29, 2022
@ace-n ace-n changed the title feat: print gcloud cmds to improve debugging feat(appengine/standard_python3): print gcloud cmds to improve debugging Nov 29, 2022
@ace-n ace-n requested a review from engelke November 29, 2022 23:28
@ace-n
Copy link
Author

ace-n commented Nov 29, 2022 •
edited
Loading

@engelke re-requesting review since I added some debugging code:

Putting the response.text assertion first should cause tests to print out HTTP responses when tests fail.

This should make debugging future test flakes easier.

@product-auto-label product-auto-label bot added the api: appengine Issues related to the App Engine Admin API API. label Nov 30, 2022
engelke
engelke approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 5910251 into main Nov 30, 2022
@engelke engelke deleted the fix-b260752619 branch November 30, 2022 18:47
@ace-n ace-n mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees

@loferris loferris

Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @engelke @loferris