-
Notifications
You must be signed in to change notification settings - Fork 6.6k
test: add retries to flaky datalab-migration test #8435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
Interesting, I didn't know/maybe I forgot that api core had a built in exponential retry. In the authoring guide we recommend |
Sounds good. Happy to make changes if needed. BTW, I was thinking the same thing about the scope of errors. I saw that the default scope for exception types is is_transient_error, which includes common "flaky" scenarios (which we can narrow down if using this class is OK). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wraps the existing test with the Google API Core Retry decorator. The Retry defaults looked fine, so I didn't override any parameters.
Fixes #8331.