-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random generation of keyring / cryptokey names #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 7, 2017
theacodes
reviewed
Feb 8, 2017
kms/api-client/snippets_test.py
Outdated
@@ -22,10 +25,14 @@ | |||
LOCATION = 'global' | |||
|
|||
# Your Google Cloud Platform KeyRing name | |||
KEYRING = 'sample-keyring-43' | |||
KEYRING = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a one-liner for you
KEYRING = ''.join(random.choice(string.ascii_lowercase + string.digits) for _ in range(12))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
theacodes
approved these changes
Feb 8, 2017
@dpebot please merge when travis passes |
Okay! I'll merge when all statuses are green and all reviewers approve. |
dpebot
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 8, 2017
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
…atform/python-docs-samples#786) * random generation of keyring / cryptokey names * Fixed formatting of keyring name and cryptokey name
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…atform/python-docs-samples#786) * random generation of keyring / cryptokey names * Fixed formatting of keyring name and cryptokey name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.