Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix Flask syntax error #7734

Merged
merged 9 commits into from
Mar 30, 2022
Merged

chore(deps): fix Flask syntax error #7734

merged 9 commits into from
Mar 30, 2022

Conversation

ace-n
Copy link

@ace-n ace-n commented Mar 29, 2022

This should fix the flaky-bot spam about

TypeError: __init__() got an unexpected keyword argument 'as_tuple'

Note: I have not tested this on App Engine itself; I'm relying on CI to catch any bugs (as they should be easily flagged syntax errors).

@ace-n ace-n requested review from yuriatgoogle and a team as code owners March 29, 2022 21:41
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 29, 2022
@ace-n ace-n requested a review from a team as a code owner March 29, 2022 22:03
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Mar 29, 2022
Copy link
Contributor

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The problem goes away in Flask 2.0.3, so 2.1.0 works too.

@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2022
@ace-n
Copy link
Author

ace-n commented Mar 30, 2022

Looks like appengine/standard/migration/storage is flaky.

I suspect a timeout increase might fix that, but I'm not sure how to do that in Python/nox.

@Mariatta @kurtisvg @yuriatgoogle can someone point me in the right direction? 😃

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2022
@Mariatta
Copy link
Contributor

Can we use the @pytest.mark.flaky decorator on the flaky test?

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ace!

@kurtisvg
Copy link
Contributor

It might be a better idea to merge this as is and address the failing testing in a different issue.

The logs for the failed test are as follows:

#
# appengine/standard/migration/storage
#

------------------------------------------------------------
- testing /workspace/appengine/standard/migration/storage
------------------------------------------------------------

 Using noxfile-template from parent folder (/workspace/appengine/standard).

nox > Running session py-2.7
nox > Creating virtual environment (virtualenv) using python2.7 in .nox/py-2-7
No user noxfile_pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > python -m pip install requests
nox > python /workspace/appengine/standard/download-appengine-sdk.py /tmp/tmpklvhz6az
Downloading App Engine SDK 1.9.91
Extracting SDK to /tmp/tmpklvhz6az
App Engine SDK installed.
nox > pytest --junitxml=sponge_log.xml
============================= test session starts ==============================
platform linux2 -- Python 2.7.18, pytest-4.6.11, py-1.11.0, pluggy-0.13.1 -- /workspace/appengine/standard/migration/storage/.nox/py-2-7/bin/python
cachedir: .pytest_cache
rootdir: /workspace, inifile: pytest.ini
collecting ... collected 1 item

main_test.py::test_index PASSED                                          [100%]

- generated xml file: /workspace/appengine/standard/migration/storage/sponge_log.xml -
========================= 1 passed in 2176.86 seconds ==========================
nox > Session py-2.7 was successful.


err: signal: killed

So it looks like the test itself is passing, but the cleanup is timing out past the time we've allowed each test to run (~30m).

@kurtisvg
Copy link
Contributor

There also seem to be a couple of tests failing lint, which is probably separate issues as well.

@kurtisvg kurtisvg merged commit 3b0d547 into main Mar 30, 2022
@kurtisvg kurtisvg deleted the fix-flask branch March 30, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants