-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): fix Flask syntax error #7734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The problem goes away in Flask 2.0.3, so 2.1.0 works too.
Looks like I suspect a timeout increase might fix that, but I'm not sure how to do that in Python/ @Mariatta @kurtisvg @yuriatgoogle can someone point me in the right direction? 😃 |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Can we use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ace!
It might be a better idea to merge this as is and address the failing testing in a different issue. The logs for the failed test are as follows:
So it looks like the test itself is passing, but the cleanup is timing out past the time we've allowed each test to run (~30m). |
There also seem to be a couple of tests failing lint, which is probably separate issues as well. |
This should fix the
flaky-bot
spam aboutNote: I have not tested this on App Engine itself; I'm relying on CI to catch any bugs (as they should be easily flagged syntax errors).