Skip to content

Remove unnecessary order_by field in a query #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2021

Conversation

jlara310
Copy link
Member

The start_at_name query has an extra order_by that causes an error.

Removes the following error:

ValueError: The "order by" field path 'state' is not present in the cursor data {'name': 'Springfield'}. All fields sent to order_by() must be present in the fields if passed to one of start_at() / start_after() / end_before() / end_at() to define a cursor.

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

The start_at_name query has an extra order_by that causes an error.

Removes the following error:

ValueError: The "order by" field path 'state' is not present in the cursor data {'name': 'Springfield'}. All fields sent to ``order_by()`` must be present in the fields if passed to one of ``start_at()`` / ``start_after()`` / ``end_before()`` / ``end_at()`` to define a cursor.
@jlara310 jlara310 requested a review from a team as a code owner April 23, 2021 20:23
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 23, 2021
@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@snippet-bot
Copy link

snippet-bot bot commented May 20, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@parthea parthea requested a review from a team as a code owner July 19, 2021 12:16
@parthea
Copy link
Collaborator

parthea commented Jul 19, 2021

@crwilcox Can we remove the Do Not Merge label?

@crwilcox crwilcox removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2021
@crwilcox
Copy link
Contributor

Yep!

@parthea
Copy link
Collaborator

parthea commented Jul 19, 2021

Thanks!

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit bf7d37b into GoogleCloudPlatform:master Aug 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2021
@jlara310 jlara310 deleted the patch-1 branch August 2, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants