-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Remove unnecessary order_by field in a query #5736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 6 commits into
GoogleCloudPlatform:master
from
jlara310:patch-1
Aug 2, 2021
Merged
Remove unnecessary order_by field in a query #5736
gcf-merge-on-green
merged 6 commits into
GoogleCloudPlatform:master
from
jlara310:patch-1
Aug 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start_at_name query has an extra order_by that causes an error. Removes the following error: ValueError: The "order by" field path 'state' is not present in the cursor data {'name': 'Springfield'}. All fields sent to ``order_by()`` must be present in the fields if passed to one of ``start_at()`` / ``start_after()`` / ``end_before()`` / ``end_at()`` to define a cursor.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
@crwilcox Can we remove the Do Not Merge label? |
Yep! |
parthea
approved these changes
Jul 19, 2021
Thanks! |
leahecole
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start_at_name query has an extra order_by that causes an error.
Removes the following error:
ValueError: The "order by" field path 'state' is not present in the cursor data {'name': 'Springfield'}. All fields sent to
order_by()
must be present in the fields if passed to one ofstart_at()
/start_after()
/end_before()
/end_at()
to define a cursor.Description
Fixes #
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)