Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove PubSub cloud-client samples #4175

Merged
merged 4 commits into from
Jun 30, 2020
Merged

chore: remove PubSub cloud-client samples #4175

merged 4 commits into from
Jun 30, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 26, 2020 •
edited
Loading

Do not merge until googleapis/python-pubsub#134 is merged, as well as the internal cl/318355428.

Update: Both prerequisites merged.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@plamut
Copy link
Contributor Author

plamut commented Jun 26, 2020 •
edited
Loading

Somebody with write access please add the do not merge label, thanks!

And verify the internal PR number in the PR description, took it from a comment.

@busunkim96
Copy link
Contributor

Internal PR number is correct and it looks like it's already been merged. 👍

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@busunkim96
Copy link
Contributor

Please edit the README.rst to have link to the root of the new samples. See text-to-speech for example

@plamut plamut marked this pull request as ready for review June 30, 2020 07:56
@plamut plamut requested review from anguillanneuf, hongalex and a team as code owners June 30, 2020 07:56
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2020
@tmatsuo tmatsuo merged commit 5aa21ca into GoogleCloudPlatform:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@hongalex hongalex Awaiting requested review from hongalex

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@plamut @busunkim96 @tmatsuo @anguillanneuf @googlebot @leahecole @kokoro-team