testing: multi project noxfile-template.py #3700

tmatsuo · 2020-05-06T23:32:49Z

This is a part of #3310 (comment)

This PR also adds cloud-run session.

tmatsuo · 2020-05-06T23:34:07Z

Note: Python 3.8 build should fail because the service account has no permission on my personal project.

tmatsuo · 2020-05-06T23:39:23Z

Oh I have typo in the project names, also there's no python3.8 presubmit.
Now python3.7 build should fail.

tmatsuo · 2020-05-06T23:43:10Z

The python3.7 build failed as expected.

tmatsuo · 2020-05-07T16:48:58Z

py-3.6 successful build with our main project

py-3.7 failed build with my personal project

I'll add the permission and run the test again.

tmatsuo · 2020-05-07T16:59:22Z

Both builds succeeded.
py-3.6
py-3.7

kurtisvg

It might be easier to propose changes to noxfile-template so it's easier to see what has changed, and also include a new file for testing/showing how its configured.

monitoring/api/v3/alerts-client/noxfile.py

tmatsuo · 2020-05-08T03:59:52Z

Initially I thought it was a good idea to have a file name .test_config.py to "hide" it from other tooling. Like hiding from coverage tool, etc.

But I changed my mind to use a valid file name as python module. For example, if the file name is test_config.py, we can just import it.

I update the PR. @kurtisvg @busunkim96 PTAL

test_config.py

noxfile-template.py

test_config.py

tmatsuo

Thanks! I think I address most of the comments. PTAL

noxfile-template.py

test_config.py

tmatsuo · 2020-05-08T21:33:03Z

Currently py3.7 build is using my personal project and it should fail because I revoked the permissoin.

tmatsuo · 2020-05-08T22:09:31Z

Well, it doesn't work as expected on Kokoro. Locally the test failed when I set BUILD_SPECIFIC_GCLOUD_PROJECT.

I need to think about why.

tmatsuo · 2020-05-08T22:49:15Z

I gave up being an armchair detective. I'm print-debugging now.

tmatsuo · 2020-05-08T23:47:07Z

Ok, now the py-3.7 buid is correctly failing.

also simplified the config stop runnint `gcloud update` add a warning about editing noxfile.py

kurtisvg · 2020-05-15T17:05:05Z

noxfile-template.py

+    # We currently look at pytest.ini for flake8 config.
+    # You can add your own exclude and ignore by using `extend-`
+    #
+    # Example config:
+    # [flake8]
+    # extend-ignore = I100
+    # extend-exclude = myapp1,myapp2
+    if os.path.isfile("pytest.ini"):
+        options += [
+            "--append-config",
+            "pytest.ini",
+        ]
+    options.append(".")
+    args = FLAKE8_COMMON_ARGS + options


nit: IMO, I don't think we should let style checks be configurable, but we can discuss on the next sync

I agree in general, but it's required for the cloud-run case.

Example:

my_proj \ e2e_test.py requirements.txt my_app1 \ main.py main_test.py requirements.txt

The lint session for the parent my_proj will report that import main is in the wrong place because it doesn't recognize the local import files correctly.

So in this case having following pytest.ini is the cleanest solution IMO:

[pytest] norecursedirs = * [flake8] extend-exclude = myapp1

This file allows to skip subdirectories both for pytest and flake8.

tmatsuo · 2020-05-15T17:52:20Z

The test failed with "google.api_core.exceptions.Aborted: 409 Too many concurrent edits to the project configuration. Please try again.", but this is within our expectation. Restarting the build.

tmatsuo added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 6, 2020

tmatsuo requested review from busunkim96 and kurtisvg May 6, 2020 23:32

blunderbuss-gcf bot assigned kurtisvg May 6, 2020

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020

tmatsuo force-pushed the multi-proj branch 2 times, most recently from 0227d0f to 959e8c0 Compare May 7, 2020 17:55

kurtisvg suggested changes May 7, 2020

View reviewed changes

monitoring/api/v3/alerts-client/noxfile.py Outdated Show resolved Hide resolved

monitoring/api/v3/alerts-client/noxfile.py Outdated Show resolved Hide resolved

tmatsuo force-pushed the multi-proj branch from 959e8c0 to 7d66737 Compare May 8, 2020 00:32

This comment has been minimized.

Sign in to view

tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020

tmatsuo force-pushed the multi-proj branch from 7d66737 to ddcf26a Compare May 8, 2020 04:39

tmatsuo marked this pull request as ready for review May 8, 2020 04:58

tmatsuo requested a review from a team as a code owner May 8, 2020 04:58

kurtisvg suggested changes May 8, 2020

View reviewed changes

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

noxfile-template.py Outdated Show resolved Hide resolved

busunkim96 reviewed May 8, 2020

View reviewed changes

noxfile-template.py Outdated Show resolved Hide resolved

noxfile-template.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

tmatsuo force-pushed the multi-proj branch from 17ee451 to 3ac6a74 Compare May 8, 2020 21:17

tmatsuo commented May 8, 2020

View reviewed changes

noxfile-template.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

test_config.py Outdated Show resolved Hide resolved

Takashi Matsuo added 18 commits May 15, 2020 06:43

testing: prototpe for multi project noxfile.py

7c1786c

correct project names

eebf78f

introduce TEST_CONFIG

d723b7d

modify noxfile-template, add default config

1dc0332

changed how we import user config

6ad4328

fix stale comments

fd7412a

use different project for python 3.6 and 3.7

308454b

fix a bug

e23b853

changed the filename

c2861c6

also simplified the config stop runnint `gcloud update` add a warning about editing noxfile.py

add BUILD_SPECIFIC_GCLOUD_PROJECT

488c0aa

use session.skip

9804c20

print debuggin

850abe7

more print debuggin

a9418b6

adding cwd to sys.path

46dadd3

removed debug print, display details of ImportError

f0c2761

use the usual test project

16e95d9

stop setting gcloud project

a2684bc

simplified the noxfile-template

e754a2a

tmatsuo force-pushed the multi-proj branch from d12323e to e754a2a Compare May 15, 2020 06:44

kurtisvg approved these changes May 15, 2020

View reviewed changes

busunkim96 approved these changes May 15, 2020

View reviewed changes

Merge branch 'master' into multi-proj

484a02f

tmatsuo merged commit 5810701 into GoogleCloudPlatform:master May 15, 2020

tmatsuo deleted the multi-proj branch May 15, 2020 18:02

testing: multi project noxfile-template.py #3700

testing: multi project noxfile-template.py #3700

Uh oh!

Conversation

tmatsuo commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmatsuo commented May 6, 2020

Uh oh!

tmatsuo commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmatsuo commented May 6, 2020

Uh oh!

tmatsuo commented May 7, 2020

Uh oh!

tmatsuo commented May 7, 2020

Uh oh!

kurtisvg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

tmatsuo commented May 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmatsuo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmatsuo commented May 8, 2020

Uh oh!

tmatsuo commented May 8, 2020

Uh oh!

tmatsuo commented May 8, 2020

Uh oh!

tmatsuo commented May 8, 2020

Uh oh!

kurtisvg May 15, 2020

Choose a reason for hiding this comment

Uh oh!

tmatsuo May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmatsuo commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tmatsuo commented May 6, 2020 •

edited

Loading

tmatsuo commented May 6, 2020 •

edited

Loading

tmatsuo commented May 8, 2020 •

edited

Loading

tmatsuo May 15, 2020 •

edited

Loading

tmatsuo commented May 15, 2020 •

edited

Loading