Skip to content

[vision] fix: add timeout for LRO result and mark it as flaky #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

[vision] fix: add timeout for LRO result and mark it as flaky #3684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vision/cloud-client/detect/vision_async_batch_annotate_images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def sample_async_batch_annotate_images(
operation = client.async_batch_annotate_images(requests, output_config)

print("Waiting for operation to complete...")
response = operation.result()
response = operation.result(90)

# The output is written to GCS with the provided output_uri as prefix
gcs_output_uri = response.output_config.gcs_destination.uri
Expand Down
1 change: 1 addition & 0 deletions vision/cloud-client/detect/vision_async_batch_annotate_images_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def bucket(storage_client):
blob.delete()


@pytest.mark.flaky(max_runs=3, min_passes=1)
def test_sample_asyn_batch_annotate_images(storage_client, bucket, capsys):
input_image_uri = os.path.join(GCS_ROOT, "label/wakeupcat.jpg")

Expand Down