Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reuse same Spanner database in Cloud Function #2763

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Feb 3, 2020

The Cloud Functions Python example creates a database object each time the function is run. This means that a new session pool is created and destroyed at each run of the function.

The example has been modified to reuse the same database object.

Closes #2762

@larkee larkee requested review from grant and a team as code owners February 3, 2020 02:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@larkee larkee force-pushed the spanner-cloud-function-fix branch from df5416b to 4754a5c Compare February 3, 2020 05:39
@larkee larkee merged commit 8215f45 into master Feb 3, 2020
@larkee larkee deleted the spanner-cloud-function-fix branch February 3, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: functions cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: spanner_read_data Cloud Functions sample doesn't reuse session pool
4 participants