-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding infinite streaming sample to samples folder, unlike indefinite… #2161
Conversation
… streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
Hi, |
@nnegrey We'd like to share this tutorial with users. It's been shared directly with developers (via the code branch) but we should get this into master and share from there. Problem: this is missing a test. The Java and Node.js versions are merged and missing tests. This has recently been tested manually and is working OK for testers. If the code generally LGTY, can we merge? Testing a code sample which is a CLI application that listens to the microphone and keeps a stream open and displays transcription results from audio sent via the microphone is non-trivial. I vote that we...
Thoughts? /cc @ecrowdus @telpirion @munkhuushmgl @danaharon |
I don't think it's worth trying to set up testing for it. but happy to merge as is today. |
I was trying to write unit test for it, and I was going to make code to
take more arguments from command line for testing purposes. I know it is a
bit complicated to write , Is that part of the reason why there was no unit
test in the first place?
…On Tue, Jul 9, 2019 at 2:56 PM Noah Negrey ***@***.***> wrote:
I don't think it's worth trying to set up testing for it. but happy to
merge as is today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2161?email_source=notifications&email_token=AK2FOZGG6XG6ISZZZLKM3QLP6UCRJA5CNFSM4HNPJAK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRU6PQ#issuecomment-509824830>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK2FOZBRU472Z4PE4PMPCYDP6UCRJANCNFSM4HNPJAKQ>
.
|
Mostly because ideally we test with a microphone (not sure how to start that) and then modifying the sample just to make it testable would further complicate the sample and make it harder for someone to distinguish and understand the relevant parts. |
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
… streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request