Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding infinite streaming sample to samples folder, unlike indefinite… #2161

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

blechdom
Copy link
Contributor

… streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

… streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2019
@blechdom
Copy link
Contributor Author

blechdom commented Jun 4, 2019

Hi,
Hoping I can get a reviewer to look at this PR!
Kristin

@beccasaurus beccasaurus requested a review from nnegrey July 9, 2019 20:34
@beccasaurus
Copy link
Contributor

@nnegrey We'd like to share this tutorial with users. It's been shared directly with developers (via the code branch) but we should get this into master and share from there.

Problem: this is missing a test. The Java and Node.js versions are merged and missing tests.

This has recently been tested manually and is working OK for testers.

If the code generally LGTY, can we merge?

Testing a code sample which is a CLI application that listens to the microphone and keeps a stream open and displays transcription results from audio sent via the microphone is non-trivial.

I vote that we...

  • open issues on nodejs-speech, java-docs-samples, and python-docs-samples to add a test to this
  • merge this, as is
  • assign test development – as well as refactoring the code so that it supports being partially embedded on a website to support a tutorial build around this code

Thoughts?

/cc @ecrowdus @telpirion @munkhuushmgl @danaharon

@nnegrey
Copy link
Contributor

nnegrey commented Jul 9, 2019

I don't think it's worth trying to set up testing for it. but happy to merge as is today.

@nnegrey nnegrey merged commit d3ba65c into master Jul 9, 2019
@nnegrey nnegrey deleted the infinite-streaming-sample branch July 9, 2019 21:56
@munkhuushmgl
Copy link
Contributor

munkhuushmgl commented Jul 9, 2019 via email

@nnegrey
Copy link
Contributor

nnegrey commented Jul 10, 2019

Mostly because ideally we test with a microphone (not sure how to start that) and then modifying the sample just to make it testable would further complicate the sample and make it harder for someone to distinguish and understand the relevant parts.

busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
telpirion pushed a commit that referenced this pull request Jan 13, 2023
…… [(#2161)](#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
…… [(#2161)](#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
telpirion pushed a commit that referenced this pull request Mar 13, 2023
…… [(#2161)](#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)

* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues

* fixed some travis ci lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants