Skip to content

Added timeout in error handling #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2018
Merged

Added timeout in error handling #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcc6213
Added timeout for error handling
anguillanneuf Aug 15, 2018
a77c40d
Added timeout for error handling
anguillanneuf Aug 15, 2018
6ecd4c8
Reformatted comments
anguillanneuf Aug 15, 2018
456a434
Rewrote comments
anguillanneuf Aug 15, 2018
80d2973
Increated timeout to pass tests
anguillanneuf Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pubsub/cloud-client/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def publish_messages_with_error_handler(project, topic_name):
topic_path = publisher.topic_path(project, topic_name)

def callback(message_future):
if message_future.exception():
# When timeout is unspecified, the exception method waits indefinitely.
if message_future.exception(timeout=30):
print('Publishing message on {} threw an Exception {}.'.format(
topic_name, message_future.exception()))
else:
Expand Down
4 changes: 2 additions & 2 deletions pubsub/cloud-client/subscriber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,12 @@ def callback(message):
# Blocks the thread while messages are coming in through the stream. Any
# exceptions that crop up on the thread will be set on the future.
try:
subscription.future.result()
# When timeout is unspecified, the result method waits indefinitely.
subscription.future.result(timeout=30)
except Exception as e:
print(
'Listening for messages on {} threw an Exception: {}.'.format(
subscription_name, e))
raise
# [END pubsub_subscriber_error_listener]


Expand Down