Added timeout in error handling #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
reviewed
Aug 15, 2018
pubsub/cloud-client/publisher.py
Outdated
| @@ -131,7 +131,9 @@ def publish_messages_with_error_handler(project, topic_name): | |||
| topic_path = publisher.topic_path(project, topic_name) | |||
|
|
|||
| def callback(message_future): | |||
| if message_future.exception(): | |||
| # Attempts to publish for 10 seconds, then times out. | |||
| # Defaults to None. | |||
There was a problem hiding this comment.
What's the behavior when timeout is None?
This comment should be more specific. Something like: When timeout is unspecified or None, the exception method waits indefinitely.
There was a problem hiding this comment.
That's much better. Let me rewrite it.
tswast
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights the timeout feature - if not specified, Pub/Sub will try to publish or subscribe indefinitely.