Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for IAP on GCE #1099

Merged
merged 19 commits into from
Sep 13, 2017
Merged

Add an example for IAP on GCE #1099

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c739b6c
Create openapi-appengine.yaml
p42ul May 4, 2017
012ba83
Add comment to openapi.yaml about deploying on App Engine.
p42ul May 9, 2017
f900dad
Add query string authentication option to Endpoints clients.
p42ul Jun 15, 2017
9ee7e57
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
p42ul Jun 15, 2017
c38340f
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
p42ul Jun 15, 2017
9ba1f52
Merge branch 'master' of https://github.com/p-buse/python-docs-samples
p42ul Jun 15, 2017
3756a2d
Fix bracket line spacing.
p42ul Jun 15, 2017
00f842f
Merge remote-tracking branch 'upstream/master'
p42ul Jul 24, 2017
5ae5482
Add openapi-appengine.yaml file for App Engine deployments.
p42ul Jul 24, 2017
3cc284d
Remove alternative auth scheme.
p42ul Jul 24, 2017
6d6602b
Change cloud.goog to appspot.com
p42ul Aug 25, 2017
c2e94ae
Merge remote-tracking branch 'google/master'
p42ul Aug 25, 2017
4619ff5
Add simple IAP app for GCE.
p42ul Sep 6, 2017
0c41b20
Merge remote-tracking branch 'google/master'
p42ul Sep 6, 2017
a6a9ac3
Add hostname to example app's response.
p42ul Sep 7, 2017
aa5fa11
Update IAP example backend and requirements.
p42ul Sep 12, 2017
197cfd1
Remove unnecessary '/healthz' endpoint, move constants after imports.
p42ul Sep 13, 2017
67007f8
Merge branch 'master' into master
Sep 13, 2017
843fc64
Fix lint
Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions iap/example_gce_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
CLOUD_PROJECT_ID = 'YOUR_PROJECT_ID'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a license header.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put constant after imports to please the linter.

BACKEND_SERVICE_ID = 'YOUR_BACKEND_SERVICE_ID'

from flask import Flask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import modules, not members, so just import flask and use flask.Flask and flask.request.

from flask import request

import platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard library imports go into the first section:

import platform

import flask

import validate_jwt


from validate_jwt import validate_iap_jwt_from_compute_engine

app = Flask(__name__)

@app.route('/')
def root():
jwt = request.headers.get('x-goog-iap-jwt-assertion')
if jwt is None:
return 'Unauthorized request.', 401
user_id, user_email, error_str = validate_iap_jwt_from_compute_engine(
jwt, CLOUD_PROJECT_ID, BACKEND_SERVICE_ID)
if error_str:
return "Error: %s" % error_str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use single quotes everywhere (except docstrings), and use .format over %.

else:
return "Hi, {}. I am {}.".format(user_email, platform.node())

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: two blank spaces between functions.

@app.route('/healthz')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, actually. I've taken it out.

def health():
return 'OK', 200

if __name__ == '__main__':
app.run(host='0.0.0.0', port=80)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use app.run(), do not bind to a specific port. Use gunicorn to run this in production.

1 change: 1 addition & 0 deletions iap/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
PyJWT==1.5.2
cryptography==2.0.3
flask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must pin versions.

google-auth==1.0.2
requests==2.18.4
requests_toolbelt==0.8.0